Hello, I recently installed s2Member pro, and I turned off “Offer to remember each customer”, and have now turned it back on, but it is not showing in the stripe popup. I’ve tried saving it a few times, and clearing the browser cache. Not sure what else to try.
Am I missing a setting, or could this be a bug? The change I made was:
Stripe Options > Stripe Account Details > Should Stripe offer to remember each customer?
Thanks
I assume that “it” refers to the current user’s email address. (That’s certainly what should be displayed.)
I’ve never tried turning it off and then back on, but this setting does work for me. So I suspect you have a plugin conflict. Turn all the other plugins off and change to the 2017 theme. Then save this setting and try again. If it works now, you had a conflict. Turning things on again one by one and testing each time should reveal the culprit.
If you can’t do this on your live site, this is one of the many reasons why you need a parallel development site to test on.
The “Remember me” checkbox is missing.
I’ve tested and it’s not a conflict. It looks like the issue is with the caching/minification of stripe.js. Stripe.js correctly sets:
allowRememberMe: '<?php echo c_ws_plugin__s2member_utils_strings::esc_js_sq($GLOBALS["WS_PLUGIN__"]["s2member"]["o"]["pro_stripe_api_allow_remember_me"]); ?>' == '1',
However, the minified file shows it’s set to false:
allowRememberMe: !1
A console log of the result of the first example, shows that it comes out as true, so the issue is happening between stripe.js and stripe.min.js, which is used on the site. I’ve temporarily hardcoded this as “true” in the plugin’s minified file and it works.
Any idea where that minification is taking place?
You are right. I see the same issue. I don’t know where the problem lies, so I’ve opened a ticket on Github and referred back to this. Please feel free to add further comments there: https://github.com/websharks/s2member/issues/1120
Geoff,
Can you be more precise on how and where you hardcoded this in the JS file?
I’m having the same issue, but my knowledge of JS is not that good.
Thanks
You’ll want to search in
src/includes/separates/gateways/stripe/stripe.min.js
for
allowRememberMe:!1,
It should appear twice, and you’ll want to replace the !1 with true
Hi Geoff,
Thanks for the update.
Works like a charm.