BUG: use of !important

#1

I mentioned this on Github as well, but since there’s hardly any activity from support/devs I’ll post it here as well.

The dashicons font family is overridden on the login page because of an !important, in inline css, generated by user settings and thus shown as a tofu.

See this image: https://user-images.githubusercontent.com/4508731/79985181-84783a80-84aa-11ea-9fc0-b90ed80355bd.png

ERROR

You see a tofu circled in red. An ‘eye’ dashicon would need to show there.

PROPOSED SOLUTION

Remove the important $i from line 110 in src/includes/classes/login-customizations.inc.php

NOTE

This only happens after saving the user settings. If not saved, default settings are used, which do not have this (css) line.

1 Like
#2

Just found out this is not a bug, but a value which can be modified with a filter.

1 Like
#3

Hi Berry.

Thanks for the heads up.

I added a new rule in s2 to give importance to the dashicons font. https://github.com/wpsharks/s2member/commit/c53be4d05d713a1ce2ba66f621fc9c190d99a11c

This seems to be an issue that almost everyone will have, so I wanted to avoid it without needing a customization. It’ll be in the next release.

:slight_smile:

#4